Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cherry Pick] Make scalers into per-task hub singletons #2967 #2984

Merged
merged 5 commits into from
Dec 5, 2024
Merged

[Cherry Pick] Make scalers into per-task hub singletons #2967 #2984

merged 5 commits into from
Dec 5, 2024

Conversation

nytian
Copy link
Collaborator

@nytian nytian commented Dec 4, 2024 •
edited
Loading

Cherry-pick the host fix for the Scale Controller (Make scalers per-task hub singletons, #2967) and Use consistent scaler IDs for target-based and scale monitor implementations (v3) (#2980) into this branch to prepare the private release of WebJobs.Extensions.DurableTask v3-rc.3.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation PR is ready to merge and referenced in pending_docs.md
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)
  • My changes do not require any extra work to be leveraged by OutOfProc SDKs
    • Otherwise: That work is being tracked here: #issue_or_pr_in_each_sdk
  • My changes do not change the version of the WebJobs.Extensions.DurableTask package
    • Otherwise: major or minor version updates are reflected in /src/Worker.Extensions.DurableTask/AssemblyInfo.cs
  • My changes do not add EventIds to our EventSource logs
    • Otherwise: Ensure the EventIds are within the supported range in our existing Windows infrastructure. You may validate this with a deployed app's telemetry. You may also extend the range by completing a PR such as this one.
  • My changes should be added to v3.x branch.
    • Otherwise: This change only applies to Durable Functions v2.x and will not be merged to branch v3.x.

@nytian nytian requested a review from cgillum December 4, 2024 20:46
@cgillum
Copy link
Member

cgillum commented Dec 4, 2024

I need to look more closely, but the source commit that you’re applying here doesn’t seem to be the final one that will actually work. Only the change in the V3 branch is 100% correct. I’m away from my desk and can’t easily confirm, but will do so when I get back.

@nytian
Copy link
Collaborator Author

nytian commented Dec 4, 2024

I need to look more closely, but the source commit that you’re applying here doesn’t seem to be the final one that will actually work. Only the change in the V3 branch is 100% correct. I’m away from my desk and can’t easily confirm, but will do so when I get back.

Oh, that should because I cherry picked the one from branch dev, not from v3.x. Let me see if I can update it now.

cgillum
cgillum approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@cgillum cgillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest changes look good!

@nytian nytian merged commit 6d098b2 into nytian/dfv3-release-rc.2 Dec 5, 2024
4 checks passed
@nytian nytian deleted the nytian/df-rc.3 branch December 5, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgillum cgillum cgillum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nytian @cgillum